From 889b946c0bce4299e1161cee6d1ffa829050537a Mon Sep 17 00:00:00 2001
From: sheychen <sheychen.public@gmail.com>
Date: Mon, 25 Jun 2018 09:44:15 +0200
Subject: [PATCH] Foreign: manual index

---
 src/Model.php          | 32 +++++++++++++++++++++++++++++---
 src/Request/Create.php |  5 +----
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/src/Model.php b/src/Model.php
index ccddc43..86c1150 100644
--- a/src/Model.php
+++ b/src/Model.php
@@ -620,6 +620,8 @@ class Model{
             if(isset($options['unique']) && $options['unique'])
                 $req->unique($column);
 
+            $index = false;
+
             if(isset($options['foreign'])){
                 $foreign = $options['foreign'];
 
@@ -638,10 +640,14 @@ class Model{
 
                 $req->foreign($column, $model::TABLE,
                     $model::getColumn(isset($foreign['field']) ? $foreign['field'] : $model::ID),
-                    isset($foreign['index']) ? $foreign['index'] : true,
                     isset($foreign['on_delete']) ? $foreign['on_delete'] : null,
                     isset($foreign['on_update']) ? $foreign['on_update'] : null);
+
+                $index = true;
             }
+
+            if(isset($options['index']) ? $options['index'] : $index)
+                $req->index($column);
         }
 
         return $req;
@@ -765,7 +771,7 @@ class Model{
      * @return self|null
      */
     public static function find($id): ?self{
-         return static::first(array($id), (static::getID().' = ?'));
+         return static::first(array($id), static::getID().' = ?');
     }
 
     /**
@@ -775,7 +781,27 @@ class Model{
      * @return self
      */
     public static function findOrFail($id): self{
-         return static::firstOrFail(array($id), (static::getID().' = ?'));
+         return static::firstOrFail(array($id), static::getID().' = ?');
+    }
+
+    /**
+     * Use static:ID to get rows
+     *
+     * @param array $ids array(int) is a good idea
+     * @return array|null
+     */
+    public static function finds(array $ids): ?array{
+         return static::all($ids, static::getID().' IN ( '.str_repeat('?, ', count($ids)-1).'? )');
+    }
+
+    /**
+     * Same as find but throw exception on null
+     *
+     * @param array $ids array(int) is a good idea
+     * @return array
+     */
+    public static function findsOrFail(array $ids): array{
+         return static::allOrFail($ids, static::getID().' IN ( '.str_repeat('?, ', count($ids)-1).'? )');
     }
 
     /**
diff --git a/src/Request/Create.php b/src/Request/Create.php
index d12ae7f..c7188df 100644
--- a/src/Request/Create.php
+++ b/src/Request/Create.php
@@ -48,10 +48,7 @@ class Create extends Request{
         return $this;
     }
 
-    public function foreign(string $name, string $table, string $column, bool $index = true, string $on_delete = null, string $on_update = null): Create{ //TODO: complex foreign
-        if($index)
-            $this->index($name);
-
+    public function foreign(string $name, string $table, string $column, string $on_delete = null, string $on_update = null): Create{ //TODO: complex foreign
         $this->foreign[$name] = compact('name', 'table', 'column', 'on_delete', 'on_update');
         return $this;
     }